Module talk:External links/sandbox
| oldid | date/time | username | edit summary |
|---|---|---|---|
| 1230959604 | 2024-06-25T17:18:24Z | Lemondoge | Simplify `links_shown` computation into an OR chain, change `conf_claims[i]['track'] =` to `conf_claims[i].track =` for consistency; simplify `for` loop logic and add comment |
| 1230950352 | 2024-06-25T16:12:12Z | Lemondoge | add backdoor for testcasing |
| 1230801711 | 2024-06-24T20:11:19Z | Lemondoge | Remove obsolete "pval" table and a commented-out debug print; change `datavalue['type']` in stringFormatter() to `datavalue.type` for consistency |
| 1230798704 | 2024-06-24T19:42:51Z | Lemondoge | |
| 1230797516 | 2024-06-24T19:34:53Z | Lemondoge | Add error to p.getLinks for if linkTemplate.prop does not exist |
| 1230791513 | 2024-06-24T18:52:04Z | Lemondoge | getLanguageData, getValuesFromWikidata - use datavalue.value.id instead of appending Q onto the numeric ID |
| 1230790124 | 2024-06-24T18:41:58Z | Lemondoge | Restore erroneously removed checks for whether or not claims/qualifiers were set to a value rather than "no value" or "custom value", incorporate regex checks directly into regexConverter, relocate boozlement "mainsnak = claim.mainsnak" that was only used once, |
| 1230775831 | 2024-06-24T16:56:59Z | Lemondoge | Rename "value" in findSiteLinksOnWikidata to "sitelink" for clarity |
| 1230774528 | 2024-06-24T16:47:40Z | Lemondoge | trim leftover comment and paranoid "or {}" |
| 1230773423 | 2024-06-24T16:40:01Z | Lemondoge | oops - typo fix (misspelled "category" as "catgeory") |
| 1230773203 | 2024-06-24T16:38:20Z | Lemondoge | Remove (most) edge-case checks for malformed Wikidata claims - they're already handled by Wikibase's soft/input constraints, and the module shouldn't be burdened with checking. |
| 1230636911 | 2024-06-23T21:05:57Z | Lemondoge | move output and category declaration in p.getLinks to right before they need to be used instead of at the start |
| 1230634272 | 2024-06-23T20:49:03Z | Lemondoge | Change "return nil" in findMainLinksLocal and findSiteLinksLocal into an explicit error condition (as it already would've errored because p.getLinks would've tried to iterate over the nil) |
| 1230631186 | 2024-06-23T20:28:12Z | Lemondoge | Another variable name change (`sitelinks` in `getSitelinkFromWikida` to `sitelink`), add comment |
| 1230630516 | 2024-06-23T20:23:33Z | Lemondoge | reconfigure variable and function names for clarity (remove `s` in getSitelinksFromWikidata, change wikidata_values in findSiteLinksLocal to wikidata_sitelink; remove accidental extraneous comment |
| 1230629425 | 2024-06-23T20:15:31Z | Lemondoge | simplify findSiteLinksOnWikidata, fix goof in findSiteLinksLocal that I made |
| 1230625295 | 2024-06-23T19:46:35Z | Lemondoge | attempted simplification of getValuesFromWikidata |
| 1230622882 | 2024-06-23T19:28:39Z | Lemondoge | add comment |
| 1229988237 | 2024-06-19T22:00:23Z | Lemondoge | Added some comments to a spot I missed, and configured the comments a bit |
| 1229986755 | 2024-06-19T21:51:07Z | Lemondoge | Improve comments |
| 1229984216 | 2024-06-19T21:33:46Z | Lemondoge | Rename `props` to `linkTemplate` to significantly improve clarity |
| 1229979898 | 2024-06-19T21:01:00Z | Lemondoge | add `break` to loop |
| 1229977961 | 2024-06-19T20:45:23Z | Lemondoge | fix deep test avoidance in getFormatterURL; testing simplifying getLanguageData - incl. making it always yield a pure string because it is always run through table.concat |
| 1229969073 | 2024-06-19T19:31:32Z | Lemondoge | change name of variable for clarity |
| 1229968080 | 2024-06-19T19:22:58Z | Lemondoge | swap deprecated alias of .getEntity(), simplify addLinkback by just directly requesting entity ID |
| 1229967578 | 2024-06-19T19:18:42Z | Lemondoge | I believe I have figured it out |
| 1229962467 | 2024-06-19T18:40:13Z | Lemondoge | That broke it; checking if the if statement optimization failed |
| 1229961844 | 2024-06-19T18:34:40Z | Lemondoge | Test using mw.wikibase.getBestStatements in formatterURL instead of manually processing for best claims; also optimize if statement slightly |
| 1179645777 | 2023-10-11T14:16:22Z | Lemondoge | improve clarity |
| 1153337074 | 2023-05-05T17:47:16Z | Lemondoge | testing if this works |
| 1153326702 | 2023-05-05T16:23:04Z | Lemondoge | fix unnecessary duplications of contLangCode |
| 1153326407 | 2023-05-05T16:20:41Z | Lemondoge | reduce #output[#output].category+1 to just 1 where applicable; here, category is known to be empty. Missed this one before |
| 1153325973 | 2023-05-05T16:17:03Z | Lemondoge | Fixed previous goof. However, I've noticed a very serious bug (which also appears to exist in the original Module:External links): findSiteLinksOnWikidata() attempts to access entity:getSitelink().langcode, which does not exist. |
| 1153073097 | 2023-05-04T01:54:02Z | Lemondoge | doot |
| 1152987746 | 2023-05-03T15:00:10Z | Lemondoge | Testing removing "v.category and #v.category" within if statement in p.getLinks; it seems that in all other functions, category is a table and is never nil or false (and if the functions return an empty table, the for loop won't run in the first place) |
| 1152985235 | 2023-05-03T14:47:13Z | Lemondoge | eliminate unnecessary double declaration of the same constant |
| 1152981006 | 2023-05-03T14:20:11Z | Lemondoge | simplifying by defaulting wikidata_values to nil instead of {} so that "wikidata_property and wikidata_values" can be changed to just "wikidata_values" |
| 1152979982 | 2023-05-03T14:12:37Z | Lemondoge | "Outer-ifying" repeated code within if statement block |
| 1152978907 | 2023-05-03T14:04:22Z | Lemondoge | Eliminating useless double-check of the existence of an object previously declared globally and already known to exist; simplifying 29-times-repeated call of "contLang:getCode()" by just changing the variable to store that value. |
| 1152905270 | 2023-05-03T00:52:22Z | Lemondoge | Trimmed if statement redundancy ("precognition" from a prior if statement) |
| 1151231560 | 2023-04-22T18:32:29Z | Lemondoge | simplification ("precognition" from prior if statement) |
| 1150547106 | 2023-04-18T19:33:18Z | Lemondoge | moar simplifications (.category[#output[#output].category+1] to .category[1] where possible); gathered the courage to finally fix the pattern matching by using % instead of \ |
| 1150543152 | 2023-04-18T19:09:36Z | Lemondoge | simplify this |
| 1150540404 | 2023-04-18T18:56:01Z | Lemondoge | i have located a former goof (accidentally used a % instead of a $ in pattern matching while merging if statement conditions) |
| 1150539111 | 2023-04-18T18:50:29Z | Lemondoge | simplified logic ("not a and not b and c" can be simplified to "not b and c" when it is known that "a and c" is false); fixed goof ("#1" back to "1") |
| 1150536639 | 2023-04-18T18:37:41Z | Lemondoge | testing if this works or if I goofed |
| 1150535811 | 2023-04-18T18:32:44Z | Lemondoge | removed excess parentheses |
| 1150167455 | 2023-04-16T17:42:39Z | Lemondoge | |
| 1150000848 | 2023-04-15T19:00:26Z | Lemondoge | Trimmed redundancy in logic statement to a simpler, equivalent version |
| 1149997061 | 2023-04-15T18:32:02Z | Lemondoge | using #output ~= 0 instead of #output >= 1, as it's likely slightly more efficient |
| 1149996606 | 2023-04-15T18:28:38Z | Lemondoge | Removed unnecessary check for #wikidata_values, but added asserts in their place - because it would have originally errored if wikidata_values was neither a table nor nil. |
| 1149845807 | 2023-04-14T19:53:21Z | Lemondoge | corrected comment |
| 1149841543 | 2023-04-14T19:19:45Z | Lemondoge | Merging nested if statement, trimming a piece of redundancy (string.find is never an empty string) |
| 1149837186 | 2023-04-14T18:42:14Z | Lemondoge | Trim #output to 1 where applicable, fix goof in prior edit |
| 1149836485 | 2023-04-14T18:36:21Z | Lemondoge | Removing excess parentheses from .find pattern matches |
| 1149804050 | 2023-04-14T14:35:09Z | Lemondoge | string.find is (presumably) slightly more efficient |
| 1149694798 | 2023-04-13T21:17:48Z | Lemondoge | make less verbose |
| 1149693703 | 2023-04-13T21:07:20Z | Lemondoge | more thing |
| 1149691889 | 2023-04-13T20:50:51Z | Lemondoge | removed obsolete thingamabobber, and made some things a bit less verbose (plus a quick reformat of one thing I did) |
| 1149691441 | 2023-04-13T20:47:51Z | Lemondoge | More simplifications that hopefully didn't break this |
| 1149689349 | 2023-04-13T20:30:56Z | Lemondoge | I _think_ this is equivalent (and probably actually fixed) |
| 1149688205 | 2023-04-13T20:21:11Z | Lemondoge | Clearing some redundancy |
| 1149676246 | 2023-04-13T18:43:52Z | Lemondoge | Eliminating usage of "local valid = ..." variables to store conditions for if statements, because the name "valid" was being reused multiple times in different scopes within the same block - which is very bad practice |
| 1149674683 | 2023-04-13T18:29:57Z | Lemondoge | testing |
| 1149672938 | 2023-04-13T18:16:14Z | Lemondoge | Simplifications and error fixes |
| 1117368045 | 2022-10-21T10:05:55Z | WOSlinker | use require('strict') instead of require('Module:No globals') |
| 941400952 | 2020-02-18T10:38:04Z | Zyxw | Create sandbox version of [[Module:External links]] |
Start a discussion about Module:External links/sandbox
Talk pages are where people discuss how to make content on විකිපීඩියා the best that it can be. You can use this page to start a discussion with others about how to improve Module:External links/sandbox.
